Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A find with no fields in the primary table results in an error #5267

Closed
AD7six opened this issue Nov 26, 2014 · 1 comment
Closed

A find with no fields in the primary table results in an error #5267

AD7six opened this issue Nov 26, 2014 · 1 comment
Assignees
@markstory
Labels
defect ORM
Milestone
3.0.0

Comments

@AD7six
Copy link
Member

AD7six commented Nov 26, 2014

For example, Article hasOne ArticleTranslation

$articles->find('all')->select(['ArticleTranslation.title'])->toArray();

Results in:

Notice: Undefined index: Articles in /var/www/cakephp.dev/plugins/ShadowTranslate/vendor/cakephp/cakephp/src/ORM/ResultSet.php on line 379
@AD7six AD7six added the defect label Nov 26, 2014
@AD7six AD7six added this to the 3.0.0 milestone Nov 26, 2014
@markstory markstory added the ORM label Nov 26, 2014
@markstory markstory self-assigned this Nov 30, 2014
markstory added a commit that referenced this issue Dec 1, 2014
@markstory
Fix notice error in ResultSet.
4a99d68 
When the originating table has no fields selected, a notice error should
not be triggered.

Refs #5267
@markstory markstory mentioned this issue Dec 1, 2014
Merged
@markstory
Copy link
Member

Closing as #5301 is open.

markstory added a commit that referenced this issue Dec 2, 2014
@markstory
Add integration test for #5267
fa9b7f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markstory markstory

Labels
defect ORM
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@markstory @AD7six