3.0, Inflector, Missing uninflected singular rule makes address->addres in bake

[spiliot]

In 2.x there is an uninflected rule for singular words ending in .*ss.

Since the inflector structure seems to have changed in 3.0, if a table contains an address_id bake looks for a table addres (note single ending s).

Obviously Inflector::rules('singular', ['/^address/i' => '\0']) does the trick for this word but I think a more global solution is needed.

[dereuromark]

I think your problem is a different one.
The inflector works as expected. You should never try to singularize an already singular word (address, plural would be addresses which correctly inflects to address then).
Thus the error must be somewhere further down the chain, where it shouldn't try to inflect "address" in the first place, as all "..._id" contain the singular form already.

[spiliot]

Indeed, good point. But is it a bug or a feature of bake trying to singularize?

[markstory]

I think the issue is bake possibly singularizing a singular value. That will go wrong in many ways.

[ADmad]

Didn't we fix the issue of bake trying to singularize already singular names?

[dereuromark]

@spiliot Would be good to know if you used the latest version and/or latest 3.0 branch and confirmed that this is still an issue.

[spiliot]

I'm still getting it in the latest 1452111e44fe2aad9.

The relevant field in the table is address_id smallint(5) UNSIGNED

Stack trace (if it is of any help):
#0 /var/www/caketest3/vendor/cakephp/cakephp/src/Database/Schema/Collection.php(92): Cake\Database\Schema\Collection->_reflect('Column', 'addres', Array, Object(Cake\Database\Schema\Table))
#1 /var/www/caketest3/vendor/cakephp/cakephp/src/Database/Schema/CachedCollection.php(62): Cake\Database\Schema\Collection->describe('addres', Array)
#2 /var/www/caketest3/vendor/cakephp/cakephp/src/ORM/Table.php(339): Cake\Database\Schema\CachedCollection->describe('addres')
#3 /var/www/caketest3/vendor/cakephp/cakephp/src/ORM/Table.php(412): Cake\ORM\Table->schema()
#4 /var/www/caketest3/plugins/Bake/src/Shell/Task/ViewTask.php(432): Cake\ORM\Table->primaryKey()
#5 /var/www/caketest3/plugins/Bake/src/Shell/Task/ViewTask.php(267): Bake\Shell\Task\ViewTask->_associations(Object(App\Model\Table\CustomersTable))
#6 /var/www/caketest3/plugins/Bake/src/Shell/Task/ViewTask.php(137): Bake\Shell\Task\ViewTask->_loadController()
#7 /var/www/caketest3/plugins/Bake/src/Shell/BakeShell.php(222): Bake\Shell\Task\ViewTask->main('Customers')
#8 [internal function]: Bake\Shell\BakeShell->all('customers')

[dereuromark]

Sounds like your associations could be defined wrongly. Can you please add them here?

[spiliot]

I don't have any associations manually setup, I'm running cake bake all customers

[ADmad]

The problem is ConventionsTrait::_modelNameFromKey() method.

Inflector::pluralize(Inflector::classify('address')); will return Addres. Swapping the order of inflection methods yields expected result.

[markstory]

I can take care of that tonight.

[markstory]

Closing as a pull request is open now.