LocaleSelectorFilter shouldn't set default locale

[pperejon]

Hello!
Recently I had some problems with the Translate behavior in a new app I'm developing using CakePHP 3.0. The prob was that translations queries were never executed because of this two reasons:

• the comparison between the current locale and the default locale at the beginning of the beforeFind.
• I loaded the LocaleSelectorFilter in my bootstrap, and this filter sets the default locale to the one in the HTTP header.

So, in this case, current locale and default locale will never differ. If you don't call explicitly I18n:locale('whatever'), or $model->local('whatever') in your code, i18n tables will never be accessed.

My suggestion is to change this line to be I18n:locale($locale). Actually, when you make a request with an accept language header, it shouldn't affect the default locale that (AFAIK) should be a static configuration parameter.

Thanks in advance and congrats for your good work!

[lorenzo]

Would you like sending us a pull request with your proposed fix?

[pperejon]

Sure! This is going to be my first collaboration to open source using git, github, unit tests, and so on. The pull request will be ready in a few minutes. Though is an ultra-simple change I hope I make no mistakes :)

[Marlinc]

@pperejon don't worry. Its easy to do and very rewarding 😄

[ADmad]

Closing are related PR is open.