CakeSchema compare not detecting field length change when changing from some non-default value to the default one

[andrej-griniuk]

This is a:

• bug
• enhancement
• feature-discussion (RFC)
• CakePHP Version: 2.8.5.
• Platform and Target: MySQL 5.6, PHP 5.6

What you did

Create a table with 'name' VARCHAR(45) column. Generate schema snapshot schema.php using Schema shell. For instance:

<?php
class AppSchema extends CakeSchema {

    public function before($event = array()) {
        return true;
    }

    public function after($event = array()) {
    }

    public $posts = array(
        'id' => array('type' => 'integer', 'null' => false, 'default' => null, 'unsigned' => true, 'key' => 'primary'),
        'name' => array('type' => 'string', 'null' => false, 'default' => null, 'length' => 45, 'collate' => 'utf8_general_ci', 'charset' => 'utf8'),
        'indexes' => array(
            'PRIMARY' => array('column' => 'id', 'unique' => 1)
        ),
        'tableParameters' => array('charset' => 'utf8', 'collate' => 'utf8_general_ci', 'engine' => 'InnoDB')
    );

} 

Generate it again and update schema_2.php removing length key on name column:

<?php
class AppSchema extends CakeSchema {

    public $file = 'schema_2.php';

    public function before($event = array()) {
        return true;
    }

    public function after($event = array()) {
    }

    public $posts = array(
        'id' => array('type' => 'integer', 'null' => false, 'default' => null, 'unsigned' => true, 'key' => 'primary'),
        'name' => array('type' => 'string', 'null' => false, 'default' => null, 'collate' => 'utf8_general_ci', 'charset' => 'utf8'),
        'indexes' => array(
            'PRIMARY' => array('column' => 'id', 'unique' => 1)
        ),
        'tableParameters' => array('charset' => 'utf8', 'collate' => 'utf8_general_ci', 'engine' => 'InnoDB')
    );

} 

Run Console/cake schema update -s 2

Expected Behavior

Welcome to CakePHP v2.8.5 Console
---------------------------------------------------------------
App : app
Path: /var/www/cakephp2/app/
---------------------------------------------------------------
Cake Schema Shell
---------------------------------------------------------------
Comparing Database to Schema...

The following statements will run.
ALTER TABLE `cakephp2`.`posts`
        CHANGE `name` `name` varchar(255) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL;
Are you sure you want to alter the tables? (y/n)

Actual Behavior

Welcome to CakePHP v2.8.5 Console
---------------------------------------------------------------
App : app
Path: /var/www/cakephp2/app/
---------------------------------------------------------------
Cake Schema Shell
---------------------------------------------------------------
Comparing Database to Schema...
Schema is up to date.

P.S. pull request to come...

[markstory]

Closing as a pull request is up now.