3.x AuthComponent ajaxLayout ?

[dereuromark]

The 3.x code seems to have some dead code:

        if (!empty($this->_config['ajaxLogin'])) {
            $controller->viewBuilder()->templatePath('Element');
            $response = $controller->render(
                $this->_config['ajaxLogin'],
                $this->RequestHandler->ajaxLayout
            );

            return $response->withStatus(403);
        }

$this->RequestHandler->ajaxLayout does not seem to exist.

maybe we can safely remove it?

[markstory]

I guess the automatic usage of AjaxView is masking this issue.

[dereuromark]

Also FormHelper::_isRequiredField() seems to be a dead method.
At least in 3.4 then.

[littleylv]

I have opened #8854 about $this->RequestHandler->ajaxLayout once before.

[dereuromark]

Time to get rid of this dead code then :)

[markstory]

One concern I have with removing this 'dead' code is that it is possible that an application developer could be doing something like:

public function beforeFilter($event)
{
   $this->RequestHandler->ajaxLayout = 'custom_ajax';
}

Us removing the cited line would 'break' this application code. I recognize that we don't have test coverage for this behavior, but it could break userland code.

[dereuromark]

With a minor 3.4 it could still be safe to communicate this as not supported.
But OK, maybe deprecating it and then cleaning it up for 4.0 is the safer option.

[markstory]

Pull request up to mark property as deprecated.

[dereuromark]

Also FormHelper::_isRequiredField() seems to be a dead method.
At least in 3.4 then.

wasnt yet discussed, though