Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Event::$_result to Event::$result. #10270

Merged
merged 1 commit into from Feb 22, 2017
Merged

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Feb 22, 2017

Removing the public property is a regression caused by #9376 which breaks existing apps/plugins.

Refs ADmad/CakePHP-HybridAuth#94 (comment)

Removing the public property is a regression caused by #9376 which breaks existing apps/plugins.
@ADmad ADmad added the defect label Feb 22, 2017
@ADmad ADmad added this to the 3.4.2 milestone Feb 22, 2017
Copy link
Contributor

@antograssiot antograssiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

Merging #10270 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #10270      +/-   ##
============================================
+ Coverage      94.9%    94.9%   +<.01%     
  Complexity    12067    12067              
============================================
  Files           421      421              
  Lines         29960    29960              
============================================
+ Hits          28433    28434       +1     
+ Misses         1527     1526       -1
Impacted Files Coverage Δ Complexity Δ
src/Event/Event.php 100% <100%> (ø) 16 <ø> (ø)
src/Cache/CacheEngine.php 93.47% <ø> (+2.17%) 19% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ec5b7...9947871. Read the comment docs.

@lorenzo lorenzo merged commit 12e8376 into master Feb 22, 2017
@lorenzo lorenzo deleted the bugfix-event-regression branch February 22, 2017 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants