Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset eager loaders before triggering before find. #10868

Merged
merged 1 commit into from Jul 6, 2017
Merged

Reset eager loaders before triggering before find. #10868

merged 1 commit into from Jul 6, 2017

Commits on Jul 6, 2017

  1. Reset eager loaders before triggering before find. 

    In #10657 I made a change to reset eager loaders when creating a clone
to fix state being shared across query clones. Because of method
ordering this resulted in the eager loader being reset *after* the
beforeFind was triggered, which dropped any contained associations added
during that event. Re-ordering the method calls allows contained
associations added during the beforeFind to be retained in the count()
query.

Refs #10813
    @markstory
    markstory committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    2d59a95 View commit details
    Browse the repository at this point in the history