Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plural messages not falling back to key. #10911

Merged
merged 2 commits into from Jul 18, 2017
Merged

Fix plural messages not falling back to key. #10911

merged 2 commits into from Jul 18, 2017

Commits on Jul 15, 2017

  1. Fix plural messages not falling back to key.

    Plural messages without a translated value did not correctly fallback to
    the message key as singular messages do. This caused undesirable
    behavior when working with plural messages.
    
    I've shifted the plural form resolution into the Translator. Now that we
    have a custom translator class this logic is better suited here instead
    of having duplicate logic in each message formatter. Interestingly our
    formatters had divergent logic for handling plurals which could cause
    some tedious to fix issues for app developers.
    
    I've not unset the `_singular` key in the Translator as userland formatters could be
    relying on those keys being passed in.
    
    Refs #10900
    markstory committed Jul 15, 2017
    Configuration menu
    Copy the full SHA
    31033e9 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2017

  1. Simpler comparison to ''

    markstory committed Jul 16, 2017
    Configuration menu
    Copy the full SHA
    3091666 View commit details
    Browse the repository at this point in the history