Ensure input passwords will be hashed even when a user doesn't exist #11095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceeram
force-pushed
the
time-based-attack
branch
from
1ef4d13
to
d53acfe
Compare
ceeram
force-pushed
the
time-based-attack
branch
from
d53acfe
to
fdb5bcd
Compare
Codecov Report
@@ Coverage Diff @@
## master #11095 +/- ##
============================================
+ Coverage 94.86% 94.91% +0.05%
- Complexity 12838 13059 +221
============================================
Files 437 437
Lines 32733 33062 +329
============================================
+ Hits 31051 31380 +329
Misses 1682 1682
Continue to review full report at Codecov.
|
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the docblock states
Input passwords will be hashed even when a user doesn't existin fact it does not. This change ensures passwords are actually hashed even when no user was found to help mitigate timing-based user enumeration attacks.