Use timing attack safe string comparison #11096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
added a commit
to cakephp/authentication
that referenced
this pull request
Aug 25, 2017
Prevent timing attacks by using a constant time comparison. Port of cakephp/cakephp#11096
Codecov Report
@@ Coverage Diff @@
## master #11096 +/- ##
============================================
+ Coverage 94.87% 94.92% +0.05%
- Complexity 12838 13059 +221
============================================
Files 437 437
Lines 32732 33060 +328
============================================
+ Hits 31053 31381 +328
Misses 1679 1679
Continue to review full report at Codecov.
|
|
Thanks! |
floriankraemer
pushed a commit
to Phauthentic/authentication
that referenced
this pull request
Mar 15, 2024
Prevent timing attacks by using a constant time comparison. Port of cakephp/cakephp#11096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use timing attack safe string comparison