New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookies not being sent by classic Dispatcher. #11097

Merged
merged 1 commit into from Aug 25, 2017

Conversation

Projects
None yet
3 participants
@markstory
Member

markstory commented Aug 25, 2017

Cookies are not arrays anymore. We lacked test coverage for this in the past.

Refs #11070

Fix cookies not being sent by classic Dispatcher.
Cookies are not arrays anymore. We lacked test coverage for this in the
past.

Refs #11070

@markstory markstory added this to the 3.5.1 milestone Aug 25, 2017

@markstory markstory added the http label Aug 25, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 25, 2017

Codecov Report

Merging #11097 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11097      +/-   ##
============================================
+ Coverage     94.86%   94.94%   +0.08%     
- Complexity    12838    13059     +221     
============================================
  Files           437      437              
  Lines         32733    33061     +328     
============================================
+ Hits          31051    31389     +338     
+ Misses         1682     1672      -10
Impacted Files Coverage Δ Complexity Δ
src/Http/Response.php 93.63% <100%> (+1.04%) 257 <0> (ø) ⬇️
src/Http/ActionDispatcher.php 100% <0%> (ø) 21% <0%> (+2%) ⬆️
src/Controller/Controller.php 99.53% <0%> (+0.07%) 102% <0%> (+25%) ⬆️
src/Http/ServerRequest.php 99.65% <0%> (+0.16%) 432% <0%> (+194%) ⬆️
src/Cache/Engine/FileEngine.php 90.05% <0%> (+1.1%) 73% <0%> (ø) ⬇️
src/Cache/CacheRegistry.php 100% <0%> (+4%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb8736...a8ad060. Read the comment docs.

codecov-io commented Aug 25, 2017

Codecov Report

Merging #11097 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11097      +/-   ##
============================================
+ Coverage     94.86%   94.94%   +0.08%     
- Complexity    12838    13059     +221     
============================================
  Files           437      437              
  Lines         32733    33061     +328     
============================================
+ Hits          31051    31389     +338     
+ Misses         1682     1672      -10
Impacted Files Coverage Δ Complexity Δ
src/Http/Response.php 93.63% <100%> (+1.04%) 257 <0> (ø) ⬇️
src/Http/ActionDispatcher.php 100% <0%> (ø) 21% <0%> (+2%) ⬆️
src/Controller/Controller.php 99.53% <0%> (+0.07%) 102% <0%> (+25%) ⬆️
src/Http/ServerRequest.php 99.65% <0%> (+0.16%) 432% <0%> (+194%) ⬆️
src/Cache/Engine/FileEngine.php 90.05% <0%> (+1.1%) 73% <0%> (ø) ⬇️
src/Cache/CacheRegistry.php 100% <0%> (+4%) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb8736...a8ad060. Read the comment docs.

@lorenzo lorenzo merged commit 2c3dd09 into master Aug 25, 2017

6 checks passed

codecov/patch 100% of diff hit (target 94.86%)
Details
codecov/project 94.94% (+0.08%) compared to fcb8736
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
stickler-ci No lint errors found.

@markstory markstory deleted the issue-11070 branch Aug 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment