Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collections when iterating over certain classes #11396

Merged
merged 6 commits into from Nov 15, 2017
Merged

Fix collections when iterating over certain classes #11396

merged 6 commits into from Nov 15, 2017

Commits on Nov 1, 2017

  1. Fix collections when iterating over certain classes 

    When a class that extends the base ArrayIterator class are iterated
over, the collection class would replace the class with a basic array or
ArrayIterator, breaking any custom logic in the original class.

This fixes the issue by checking if the class is an ArrayIterator,
rather than if it is simply a instance of ArrayIterator.
    @dakota
    dakota committed Nov 1, 2017
    Copy the full SHA
    2db64da View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2017

  1. Add test for array iterator issue

    @dakota
    dakota committed Nov 2, 2017
    Copy the full SHA
    38e7646 View commit details
    Browse the repository at this point in the history

  2. Revert change to toArray

    @dakota
    dakota committed Nov 2, 2017
    Copy the full SHA
    62ddb47 View commit details
    Browse the repository at this point in the history

  3. Silly change to make PHPStan happy

    @dakota
    dakota committed Nov 2, 2017
    Copy the full SHA
    5b14976 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2017

  1. Revert "Silly change to make PHPStan happy" 

    This reverts commit 5b14976.
    @dakota
    dakota committed Nov 15, 2017
    Copy the full SHA
    f859919 View commit details
    Browse the repository at this point in the history

  2. Ignore phpstan error

    @dakota
    dakota committed Nov 15, 2017
    Copy the full SHA
    74ace8a View commit details
    Browse the repository at this point in the history