2.x Build and Pass with PHP7.2 #11619
Conversation
|
Now you are getting somewhere, errors become visible:
Seem to be the issues left for PHP7.2 compatibility. |
These are a big headache to fix. |
tenkoma
force-pushed
the
2.x-build-php72
branch
from
8e7c071
to
701519c
Compare
I didn't fail when I only ran
Probably related to the next ticket. |
tenkoma
changed the title
…, 'user')` can't be executed, so delete.
| // https://github.com/php/php-src/commit/a93a51c3bf4ea1638ce0adc4a899cb93531b9f0d | ||
| if (version_compare(PHP_VERSION, '7.2.0', '>=')) { | ||
| unset($sessionConfig['ini']['session.save_handler']); | ||
| } |
There was a problem hiding this comment.
I referred to the following code. However, I think it is PHP 7.2.0+ that this setting cannot be done
cakephp/src/Network/Session.php
Lines 111 to 114 in 8b3905a
- session.c on PHP 7.1.0: https://github.com/php/php-src/blob/php-7.1.0/ext/session/session.c#L549-L574
- session.c on PHP 7.2.0: https://github.com/php/php-src/blob/php-7.2.0/ext/session/session.c#L559-L563
There was a problem hiding this comment.
I think you have the correct code here. There is an open issue for database sessions in PHP7.2 (#11628)
tenkoma
changed the title
| @@ -328,7 +328,7 @@ public function bakeActions($controllerName, $admin = null, $wannaUseSession = t | |||
| * @param array $components Components to use in controller | |||
| * @return string Baked controller | |||
| */ | |||
| public function bake($controllerName, $actions = '', $helpers = null, $components = null) { | |||
| public function bake($controllerName, $actions = '', $helpers = array(), $components = array()) { | |||
There was a problem hiding this comment.
Why did you change this signature?
There was a problem hiding this comment.
It is a change to correct errors that occur in the following lines.
But it is not BC with existing applications.
Make null be converted to array().
…gnature for backward compatibility.
| $this->out("\n" . __d('cake_console', 'Baking controller class for %s...', $controllerName), 1, Shell::QUIET); | ||
|
|
||
| if (is_null($helpers)) { |
There was a problem hiding this comment.
We usually favor $helpers === null as it uses fewer function calls.
Refs #11346
In this Pull Request, Installed the
mcryptextension from pecl in the CI so that we can test it.pear config-set preferred_state snapshot. Because pecl's mcrypt package issnapshot, is notstablehttps://pecl.php.net/package/mcryptpecl installto execute first. Because failscomposer require "phpunit/phpunit=$PHPUNIT"