Add formatoutput option to Xml::fromArray #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo
added a commit
that referenced
this pull request
Mar 13, 2013
Add formatoutput option to Xml::fromArray
| @@ -150,6 +150,7 @@ protected static function _loadXml($input, $options) { | |||
| * ### Options | |||
| * | |||
| * - `format` If create childs ('tags') or attributes ('attribute'). | |||
| * - `formatOutput` Returns formatted Xml | |||
There was a problem hiding this comment.
What about calling this option pretty? Its often called that in other tools. For example elasticsearch.
There was a problem hiding this comment.
Sounds good to me, will change that
2013/3/13 Mark Story notifications@github.com
In lib/Cake/Utility/Xml.php:
@@ -150,6 +150,7 @@ protected static function _loadXml($input, $options) {
Options
- -
formatIf create childs ('tags') or attributes ('attribute').
- * -
formatOutputReturns formatted XmlWhat about calling this option pretty? Its often called that in other
tools. For example elasticsearch.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1175/files#r3353416
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.