Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated paths in all Errrors #120

Merged
merged 4 commits into from Jun 14, 2011
Merged

Updated paths in all Errrors #120

merged 4 commits into from Jun 14, 2011

Conversation

mamchenkov
Copy link
Contributor

No description provided.

@@ -22,7 +22,7 @@
</p>
<p class="error">
<strong><?php echo __d('cake_dev', 'Error'); ?>: </strong>
<?php echo __d('cake_dev', 'Create %1$s%2$s in file: %3$s.', '<em>' . $controller . '::</em>', '<em>' . $action . '()</em>', APP_DIR . DS . 'controllers' . DS . Inflector::underscore($controller) . '.php'); ?>
<?php echo __d('cake_dev', 'Create %1$s%2$s in file: %3$s.', '<em>' . $controller . '::</em>', '<em>' . $action . '()</em>', APP_DIR . DS . 'Controller' . DS . Inflector::underscore($controller) . '.php'); ?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The controller name has to be CamelCased.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll correct it in a few minutes.

@renan
Copy link
Contributor

renan commented Jun 14, 2011

First of all, thank you for your patch.
The more we approach to RC releases the more we need these fixes, even small ones.

I made few suggestions about what else needs to change, I possible missed few.
And also needs to check if $file is actually the right name.

So, thanks again.
Let me know if you can provide an extra commit with these things to this request.

@mamchenkov
Copy link
Contributor Author

No problem. I'll fix those too in a few minutes.

@mamchenkov
Copy link
Contributor Author

OK, now it should be somewhat better. I did a few tests on my install and all paths seem to be correct. Please let me know if something else needs fixing.

renan added a commit that referenced this pull request Jun 14, 2011
Updated paths in all Errrors
@renan renan merged commit e803111 into cakephp:2.0 Jun 14, 2011
@renan
Copy link
Contributor

renan commented Jun 14, 2011

Well done, thank you!

@markstory
Copy link
Member

This broke a few tests for the exception rendering, I'll take care of them. But in the future its good to run the tests when making changes :)

@mamchenkov
Copy link
Contributor Author

My bad. I'll keep it in my mind for the next time. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants