Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected annotation for Debugger::exportVar() method. #12306

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

dmromanov
Copy link
Contributor

Debugger::exportVar() in fact accepts any variables, not only strings. See annotations for _export() function in the same class.

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #12306 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #12306      +/-   ##
============================================
- Coverage     91.94%   91.93%   -0.01%     
  Complexity    13552    13552              
============================================
  Files           467      467              
  Lines         34823    34823              
============================================
- Hits          32019    32016       -3     
- Misses         2804     2807       +3
Impacted Files Coverage Δ Complexity Δ
src/Error/Debugger.php 94.55% <ø> (ø) 135 <0> (ø) ⬇️
src/Cache/CacheRegistry.php 95.83% <0%> (-4.17%) 11% <0%> (ø)
src/Cache/Engine/FileEngine.php 89.01% <0%> (-1.1%) 73% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d6f8f...bdd5170. Read the comment docs.

@dereuromark dereuromark merged commit 6350dfd into cakephp:master Jun 28, 2018
@saeideng saeideng added this to the 3.6.7 milestone Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants