Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate code from IntegerType #12803

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Remove duplicate code from IntegerType #12803

merged 2 commits into from
Dec 14, 2018

Conversation

burzum
Copy link
Contributor

@burzum burzum commented Dec 11, 2018

No description provided.

@burzum burzum self-assigned this Dec 11, 2018
@dereuromark dereuromark added this to the 3.7.1 milestone Dec 11, 2018
markstory
markstory approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem ok to me. This will add more method calls which in aggregate can add up, but I don't think that will matter in practical use cases.

@markstory markstory merged commit 41a16ec into cakephp:master Dec 14, 2018
@markstory markstory deleted the duplicate-code branch December 14, 2018 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstory markstory markstory approved these changes

@lorenzo lorenzo Awaiting requested review from lorenzo

Assignees

@burzum burzum

Labels
database
Projects
None yet
Milestone
3.7.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@burzum @markstory @dereuromark