Update limitControl in PaginatorHelper.php #12806
Conversation
add options for form element attributes
initialize $fopt as array and then remove form array key from options
|
Tests needed for the change. Also please follow coding standards: https://travis-ci.org/cakephp/cakephp/jobs/466877198#L611 |
|
Moving to 3.next as we don't merge new features into master. |
use coding standard as suggested.
Codecov Report
@@ Coverage Diff @@
## 3.next #12806 +/- ##
============================================
+ Coverage 90.42% 90.42% +<.01%
- Complexity 14033 14034 +1
============================================
Files 522 522
Lines 36105 36110 +5
============================================
+ Hits 32647 32653 +6
+ Misses 3458 3457 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 3.next #12806 +/- ##
============================================
+ Coverage 90.42% 90.42% +<.01%
- Complexity 14033 14034 +1
============================================
Files 522 522
Lines 36105 36110 +5
============================================
+ Hits 32647 32653 +6
+ Misses 3458 3457 -1
Continue to review full report at Codecov.
|
| @@ -1239,7 +1239,16 @@ public function implementedEvents() | |||
| */ | |||
| public function limitControl(array $limits = [], $default = null, array $options = []) | |||
| { | |||
| $out = $this->Form->create(null, ['type' => 'get']); | |||
| $form_options = [ | |||
There was a problem hiding this comment.
camelCase for variables
and a test csss is missing. otherwisw looks good
|
ping @yosiazwan : any update on this one? |
|
Closing due to lack of follow up from author. |
Add options for form element attributes.