debug() in CLI should include newline.. #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not, two debug() statements after each other is very hard to read, as the #### separater is on the same line
|
Doesn't this break the test cases for debug? |
|
@lorenzo most likely yes; I'll modify them if there is consensus that the fix makes sense :) |
|
Just wait for few mins and travis will show the fails 😄 |
|
Basically BasicsTest.php (line 699 ff) |
|
I think the extra newline makes sense. You just need to update the tests 😄 |
markstory
added a commit
that referenced
this pull request
May 29, 2013
…e-newline debug() in CLI should include newline..
|
I'll fix up the tests. |
markstory
added a commit
that referenced
this pull request
May 29, 2013
|
Tests fixed in 06cf62a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not, two debug() statements after each other is very hard to read, as the #### separater is on the same line