Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormContext error() should return array with error names as keys. #13250

Merged
merged 1 commit into from May 18, 2019

Conversation

robertpustulka
Copy link
Member

Fixes #13235

@robertpustulka robertpustulka added this to the 3.7.8 milestone May 17, 2019
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #13250 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #13250      +/-   ##
============================================
- Coverage     90.95%   90.94%   -0.01%     
  Complexity    14069    14069              
============================================
  Files           522      522              
  Lines         36177    36177              
============================================
- Hits          32904    32901       -3     
- Misses         3273     3276       +3
Impacted Files Coverage Δ Complexity Δ
src/View/Form/FormContext.php 94.11% <100%> (ø) 29 <0> (ø) ⬇️
src/Cache/CacheRegistry.php 95.83% <0%> (-4.17%) 11% <0%> (ø)
src/Cache/Engine/FileEngine.php 89.28% <0%> (-1.03%) 76% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedcb68...fcdfd9a. Read the comment docs.

@markstory markstory merged commit 2b8aff6 into cakephp:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormContext removes error name keys
3 participants