Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TableSchema::TYPE_CHAR to replace fixed-length strings #13843

Merged
merged 2 commits into from Nov 7, 2019
Merged

Added TableSchema::TYPE_CHAR to replace fixed-length strings #13843

merged 2 commits into from Nov 7, 2019

Conversation

karmicdice
Copy link
Contributor

@karmicdice karmicdice mentioned this pull request Nov 5, 2019
Closed
@ADmad ADmad added this to the 4.0.0 milestone Nov 5, 2019
othercorey
othercorey reviewed Nov 5, 2019
View reviewed changes
Copy link
Member

@othercorey othercorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string types in testDescribeTable() in sqlserverschematest.php don't need fixed => null. This is causing SqlServer unit test to fail.

@othercorey othercorey changed the title Char columns are migration diffed as Varchar #362 Added TableSchema::TYPE_CHAR to replace fixed-length strings Nov 6, 2019
@karmicdice
Copy link
Contributor Author

The string types in testDescribeTable() in sqlserverschematest.php don't need fixed => null. This is causing SqlServer unit test to fail.

Yea. Thanks mate..
Noticed it. AppVeyor failed there.

@markstory
Copy link
Member

Looks good to me 👍

othercorey
othercorey approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@othercorey othercorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@markstory markstory merged commit 0a646fa into cakephp:4.x Nov 7, 2019
@markstory markstory mentioned this pull request Nov 7, 2019
Merged
saeideng added a commit to cakephp/migrations that referenced this pull request Apr 17, 2020
@saeideng
unset fixed from schema list
e94c007 
fixed has beed removed from TableSchema
Refs: cakephp/cakephp#13843
@saeideng saeideng mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADmad ADmad ADmad approved these changes

@othercorey othercorey othercorey approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@karmicdice @markstory @ADmad @othercorey