Fix CS errors and issues reported by static analyzers #14189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
reviewed
Jan 19, 2020
src/Console/HelperRegistry.php
Outdated
| @@ -55,8 +55,7 @@ public function setIo(ConsoleIo $io): void | |||
| * Part of the template method for Cake\Core\ObjectRegistry::load() | |||
| * | |||
| * @param string $class Partial classname to resolve. | |||
| * @return string|null Either the correct class name or null. | |||
| * @psalm-return class-string | |||
| * @return class-string|null Either the correct class name or null. | |||
There was a problem hiding this comment.
TypeResolver doesn't seem to handle class-string yet. Maybe I can add it in a PR.
dereuromark
reviewed
Jan 19, 2020
src/Cache/CacheRegistry.php
Outdated
| @@ -36,8 +36,7 @@ class CacheRegistry extends ObjectRegistry | |||
| * Part of the template method for Cake\Core\ObjectRegistry::load() | |||
| * | |||
| * @param string $class Partial classname to resolve. | |||
| * @return string|null Either the correct classname or null. | |||
| * @psalm-return class-string | |||
| * @return class-string|null Either the correct classname or null. | |||
|
Opened PR for class-string support in TypeResolver so we don't have to rely on psalm-specific annotations. |
|
Both phpstan and psalm (and even phan) support |
|
Maybe not IDEs and other tools? For them it is still string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The phpcs ignores can be removed once slevomat/coding-standard#851 is addressed.