Fix the console cli #1468
Merged
Fix the console cli #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does that shell even do? Glorified version of https://github.com/nodesagency/cake-interactive-shell ? |
|
I've never used it, I only know/remember it exists when someone points out it's broken (maybe that doesn't happen as often as I imply - it's simply the only trigger). |
|
I am pretty certain most of us never used it. It seems to be to be pretty pointless when having test suite and test cases at hand doing the same without running in regressions :). I would deprecate it. |
|
Didn't even know it was there until today. |
|
This is great stuff! Merge it whenever you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems so often to get left behind.
The use of a case with various checks seems to be fragile and break (it is currently broken in 2.4) - so rewritten to not be one method with a huge case statement in it.
I'm not sure if keeping this shell is a good idea, perhaps it should be deprecated - if not it needs a unit test and to be keep up to date.