-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add phpunit 9 support (to allow testing on PHP 8) #14885
Conversation
This looks like a fun failure. |
Errors on PHP 8:
|
Last commit to Aura.Intl was on Jan 20, 2017. Even running it's test suite with a recent phpunit version would be non trivial. I think it would be better if we just copy the classes we need and move on. |
|
Good, so just need to wrap the call in a PHP version check. |
We can commit this with failures allowed so people can test fixes or will have to wait work on them here. |
Once #14885 is merged and forwarded to |
5d255e4
to
2a194c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
This is ready to merge now. The only remaining failure for DateTimeType marshalling needs a fix in Chronos (which isn't an easy fix) and dealing with the warnings for usage of |
This allows our testsuite to be used with PHP 8.5+ & 9+ without deprecation warnings.
…asted to float. The check behaves different in PHP 8 causing test failures.
No description provided.