Add support for ignoring deprecations by path #14925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Being able to have deprecations on globally but silence problematic parts of your application or a noisy plugin that can't be upgraded just yet allows developers more control when upgrading. Instead of having to hope they don't add new deprecations they can fix a part of their application and then remove it from the deprecation ignore patterns. I've used glob here instead of regex as I don't think the power of regex is needed for this. Refs #14915
garas
reviewed
Aug 23, 2020
garas
reviewed
Aug 25, 2020
I think \ might be causing problems with fnmatch() on windows as builds have failed a few times.
garas
reviewed
Aug 27, 2020
garas
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to have deprecations on globally but silence problematic
parts of your application or a noisy plugin that can't be upgraded just
yet allows developers more control when upgrading.
Instead of having to hope they don't add new deprecations they can fix
a part of their application and then remove it from the deprecation
ignore patterns.
I've used glob here instead of regex as I don't think the power of regex
is needed for this.
Refs #14915
Refs cakephp/app#803