Restrict Validation::time() so it requires minutes not just hours #14969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you mean as an alternative to #14929? |
|
Either way. I'm suggesting we treat it as an implementation bug not a documentation bug. |
ADmad
approved these changes
Sep 9, 2020
othercorey
added a commit
to cakephp/docs
that referenced
this pull request
Sep 9, 2020
markstory
added a commit
that referenced
this pull request
Dec 10, 2020
Back-porting from #14969 on CakePHP 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing this as the alternative to #14930. I don't think most users expect hours only to pass validation in a 24-hour format.
PHP DateTime will not parse hours-only when passed to the constructor so it would require a custom format for users that want to accept this input.
https://3v4l.org/iYb3Q
Did not adjust the am/pm (meridian) format which will validate something like "1 pm". These formats are never marshaled so I don't know when users expect to use them.