Allow setting path constants in app/Console/cake.php as you can in webro... #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't the cli flag take precedence over the defined constant? That might get a bit messy though. |
|
@markstory Not sure what you mean. The cli flag |
|
Can we make all constants conditional? I'd like to be able to set all of them from CLI or nginx via ENV vars. |
|
@josegonzalez With this patch all are. ROOT, APP_DIR, APP are the only ones that aren't conditional since they are already configurable through cli params. |
|
ah k. |
lorenzo
added a commit
that referenced
this pull request
Aug 11, 2013
Allow setting path constants in app/Console/cake.php as you can in webro...
|
Ignore me, my comment made no sense in retrospect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ot/index.php