Making CakeTime display 'about X ago' when time passed is lower than acc... #1511
Conversation
|
👍 for |
| return __d('cake', '%s ago', $relativeDate); | ||
| if ($relativeDate) { | ||
| return __d('cake', '%s ago', $relativeDate); | ||
| } else { |
There was a problem hiding this comment.
you can spare the else statement as the if has a return inside
|
You should add a second test with the different direction (so that $backwards is false). |
|
@dereuromark It now says "in about an hour" for future times where timeTo is less than accuracy. |
|
This makes sense to me 👍 |
|
@ankr Squash it, please. Then it looks pretty much good to go. |
| return __d('cake', 'about an hour ago'); | ||
| } | ||
|
|
||
| return __d('cake', 'about a %s ago', $fWord); |
There was a problem hiding this comment.
Is this effectively untranslatable? Is it going to produce:
hace un **year**
?
There was a problem hiding this comment.
Correction, this will make it impossible to translate correctly (ignoring whether $fWord is translated or not) in some/many languages, using spanish:
Hace aproximadamente un segundo
Hace aproximadamente un minuto
Hace aproximadamente una hora
Hace aproximadamente un dia
Hace aproximadamente un**a** semana
Hace aproximadamente un mes
Hace aproximadamente un año
I suggest to use the same kind of fixed strings as for hour in all cases.
There was a problem hiding this comment.
Maybe use an array of intervals => their translated values to make the code shorter/easier to read
…accuracy Removing unnecessary else Also support 'about' times for future times Make 'about' times translateable in all languages
| @@ -820,48 +820,76 @@ public static function timeAgoInWords($dateTime, $options = array()) { | |||
| return __d('cake', 'on %s', date($format, $inSeconds)); | |||
| } | |||
|
|
|||
| $f = $accuracy['second']; | |||
| $fWord = $accuracy['second']; | |||
There was a problem hiding this comment.
Just what the framework needed. Few $fWords .
|
This looks good to me 👍 |
Making CakeTime display 'about X ago' when time passed is lower than acc...
...uracy
This would produces an incorrect value:
CakeTime::timeAgoInWords(strtotime('-58 minutes'), array('accuracy' => 'hour'));
Old result: " ago" (notice empty space)
New result: "about an hour ago"