enable test.php webrunner again and fix a missing namespace #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. I think test.php got lost in a merge conflict like you said. Some of the 2.3 -> 3.0 merges were pretty epic which ~100 conflicted files so it was probably not malicious if test.php got lost. |
|
That's what I figured backtracing the logs. :) |
markstory
added a commit
that referenced
this pull request
Aug 31, 2013
enable test.php webrunner again and fix a missing namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few months back the test.php testrunner file got removed during a 2.4 merge. Probably due to convenience during a merge conflict.
Anyway, during a discussion some including me saw the usefulness in 3.0 still supporting the webrunner as it eases the start into testing.
This moves the test.php webrunner back into 3.0.
For it to work I had to first add a missing use, though.
Note that this might not be the best approach regarding the current overhead in TestSuiteDispatcher::run() - also in light of its possible removal. Open for discussion on how to best proceed.