Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log classname in skeleton #1607

Merged
merged 1 commit into from Sep 5, 2013
Merged

Fix log classname in skeleton #1607

merged 1 commit into from Sep 5, 2013

Conversation

chadrien
Copy link
Contributor

@chadrien chadrien commented Sep 5, 2013

Fixes "logger class File does not implement a write method."
It probably tries to use the utility File class instead of the logger

Fixes "logger class File does not implement a write method."
It probably tries to use the utility File class instead of the logger
markstory added a commit that referenced this pull request Sep 5, 2013
Fix log classname in skeleton
@markstory markstory merged commit 6e67489 into cakephp:master Sep 5, 2013
@ADmad
Copy link
Member

ADmad commented Sep 5, 2013

Including the Log suffix when specifying engine was actually dropped in 2.4. There are tests for it and I also confirmed in an app that just using 'engine' => 'File' works as expected.

@ravage84
Copy link
Member

ravage84 commented Sep 5, 2013

I agree with @ADmad. @chadrien how did you get that error? Please provide some code.

Can somebody please revert this PR's changes?

@ADmad
Copy link
Member

ADmad commented Sep 5, 2013

I have already reverted these changes 29d0e26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants