Allow naming plugin classes matching the plugin name. #16374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having numerous classes named "Plugin" in your app.
othercorey
reviewed
Mar 11, 2022
| @@ -17,6 +17,6 @@ | |||
|
|
|||
| use Cake\Core\BasePlugin; | |||
|
|
|||
| class Plugin extends BasePlugin | |||
| class TestPluginThreePlugin extends BasePlugin | |||
There was a problem hiding this comment.
You know what they say about naming things in programming :)
You mean "suffix", yes? |
othercorey
reviewed
Mar 11, 2022
| { | ||
| public function bootstrap(PluginApplicationInterface $app): void | ||
| { | ||
| Configure::write('ParentPlugin.bootstrap', true); | ||
| Configure::write('Named.bootstrap', true); |
There was a problem hiding this comment.
I don't see any changes for this name lookup. Is it dependent on anything?
There was a problem hiding this comment.
See the BaseApplicationTest.
Yes, typo :) |
|
For reference Symfony bundle classes are names similarly. For e.g. the "TwigBundle" has the class |
markstory
approved these changes
Mar 11, 2022
|
It would be good to update the docs too. |
ADmad
added a commit
to cakephp/docs
that referenced
this pull request
Mar 11, 2022
ADmad
added a commit
to cakephp/bake
that referenced
this pull request
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having numerous classes named "Plugin" in your app. You can now name the class the same as the plugin name with a "Plugin" suffix. For e.g.
ADmad\I18n\I18nPlugininstead ofADmad\I18n\Plugin.