Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original (legacy syntax) was:
which is meaning wise identical to
at least in the given context, since there was no other way of stating an object collection.
Now, given the legacy syntax there was always not clear which one was meant, as it could also mean
which is the current documentation - and also reflects reality (partially).
However, that is a different meaning, as other code examples show, where it is either an object, or an array.
Not a collection of either object or array with the same type inside.
Those are both collection types here (object + array with each the same key).
As such, shoudnt those be fixed up to
then? As both are the collection we want to iterate over in the end.
There could in the future also be more normalized versions of this, e.g.
But for now the verbose syntax is only supported by tooling.
PS: This does need small docblock updates on the actual interface, to make it "generic", afaik.