Add methods to RulesChecker to remove rules. #17634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks reasonable, but I don't know much about the use cases. |
markstory
reviewed
Mar 23, 2024
Comment on lines
+207
to
+208
| $rules->remove('ruleName'); | ||
| $this->assertTrue($rules->check($entity, RulesChecker::CREATE)); |
There was a problem hiding this comment.
We should have tests for the other remove* methods as well.
markstory
added a commit
to cakephp/docs
that referenced
this pull request
Apr 1, 2024
ADmad
added a commit
to cakephp/docs
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #17610
I'll add more tests for code coverage once the PR is approved in principle.