Check all fields for new entities. #17668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this have been a merge error maybe? with resolving a conflict? |
|
What restored this behavior? Can you explain more? |
|
I also dont see how this was changed as "revert" as you claim. |
|
I am not sure why but without this change our unique rules do not work for some cases. The fix is most definitely wrong and its an attempt to figure it out. Sorry for the mix up. I updated the comment above. |
|
Turns out the issue was that we had rules with the same name. The last rule with the same name "won" and effectively cancelled the previous ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why but it restored behavior to 4.x. Without the change it skips the check for new entities.
For some reason: $entity->extract($this->_fields, true) returns [] for some new entities that it wasnt before. This was found during phpunit when testing our 5.x upgrade branch.