a test in the MootoolsEngineHelper testcase was ignoring asserts #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch. expectError should probably be removed from all the tests in 2.0. The PHPUnit annotations are much better for this use. |
|
What about the idea of helpers throwing exceptions? This function could throw a MissingParameterException |
|
I think an exception here makes sense. |
|
Landed in [aa45452]. I left the trigger_error as is for now, but it could be an exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test for MootoolsEngineHelper::drop() there is a expectError(). Because of this assert the asserts on the next lines are never run and never tests the actual drop() function.
I fixed this by splitting them up and moving the error checking assert into its own test function.