Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

a test in the MootoolsEngineHelper testcase was ignoring asserts #196

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

In the test for MootoolsEngineHelper::drop() there is a expectError(). Because of this assert the asserts on the next lines are never run and never tests the actual drop() function.

I fixed this by splitting them up and moving the error checking assert into its own test function.

Owner

markstory commented Sep 9, 2011

Thanks for the patch. expectError should probably be removed from all the tests in 2.0. The PHPUnit annotations are much better for this use.

What about the idea of helpers throwing exceptions?

This function could throw a MissingParameterException

Owner

markstory commented Sep 9, 2011

I think an exception here makes sense.

Owner

markstory commented Sep 10, 2011

Landed in [aa45452]. I left the trigger_error as is for now, but it could be an exception.

@markstory markstory closed this Sep 10, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment