Refactoring PhpReader::read() to check for .php file first #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or when there's a directory with the same name.
ADmad
added a commit
that referenced
this pull request
Oct 17, 2011
Refactoring PhpReader::read() to check for .php file first
westernmagic
pushed a commit
to westernmagic/cakephp
that referenced
this pull request
Oct 17, 2011
helps fix a race condition where dbo->defaultConditions could cause additional data loss. Fixes cakephp#250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance optimization:
PhpReader files are php files by default (including all
Cake/Config/files). Try to include them first.Fixed error when there's a directory with the same name.
Consider
APP/Config/config/orAPP/Config/settings/Then
Configure::load('config');should throw an exception by reader, not PHP warning.