Refactoring PhpReader::read() to check for .php file first #250

Merged
merged 1 commit into from Oct 17, 2011

Projects

None yet

2 participants

@majna

Performance optimization:
PhpReader files are php files by default (including all Cake/Config/ files). Try to include them first.

Fixed error when there's a directory with the same name.
Consider APP/Config/config/ or APP/Config/settings/

Then Configure::load('config'); should throw an exception by reader, not PHP warning.

  • passes tests
@majna majna Refactoring PhpReader::read() to check for .php file first. Fixed err…
…or when there's a directory with the same name.
f0d10b4
@ADmad ADmad merged commit 1432e78 into cakephp:2.0 Oct 17, 2011
@westernmagic westernmagic pushed a commit to westernmagic/cakephp that referenced this pull request Oct 17, 2011
@markstory markstory Adding specific conditions to model->delete's call to dbo->delete. This
helps fix a race condition where dbo->defaultConditions could cause
additional data loss.  Fixes #250
e8678b3
@jippi jippi pushed a commit that referenced this pull request May 11, 2012
@markstory markstory Adding specific conditions to model->delete's call to dbo->delete. This
helps fix a race condition where dbo->defaultConditions could cause
additional data loss.  Fixes #250
22938d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment