Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 - Fix EagerLoader docblocks #2760

Merged
merged 1 commit into from Feb 3, 2014
Merged

Conversation

bcrowe
Copy link
Contributor

@bcrowe bcrowe commented Feb 3, 2014

No description provided.

@dereuromark
Copy link
Member

It could probably also just return an empty array instead of void - to always return type array. If that makes sense.

@bcrowe
Copy link
Contributor Author

bcrowe commented Feb 3, 2014

Yup, doesn't look like anything is dependent on the void return. Either works for me.

Edit: technically a return w/o a value is a null return. But same things applies.

@dereuromark
Copy link
Member

I'd usually go for the more consistent return type(s). But let's see what the others say.

@markstory
Copy link
Member

I'm pretty sure the thing|void pattern is pretty consistent where we use combined getter/setter methods.

ADmad added a commit that referenced this pull request Feb 3, 2014
3.0 - Fix EagerLoader docblocks
@ADmad ADmad merged commit 3a440ce into cakephp:3.0 Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants