Removed Router::parseExtensions(). #3406
Conversation
Just use Router::setExtensions() instead. setExtensions() now also takes a single extension as string for first param.
|
I don't like the name "setExtensions", I would rather keep "parseExtensions" and make it behave differently |
|
I would be happy to just rename |
|
There's also |
|
|
|
👍 for @lorenzo suggestion :) |
Also renamed Route::setExtensions() to Route::parseExtensions() for consistency.
|
👍 Good idea! |
|
👍 for merging parseExtensions and setExtensions, this wasn't possible in 2014-04-28 12:23 GMT+02:00 Mark notifications@github.com:
|
| @@ -128,7 +128,7 @@ public function __construct($template, $defaults = [], array $options = []) { | |||
| * @param array $extensions The extensions to set. | |||
| * @return void | |||
| */ | |||
| public function setExtensions(array $extensions) { | |||
| public function parseExtensions(array $extensions) { | |||
There was a problem hiding this comment.
I prefer the old var args interface personally.
There was a problem hiding this comment.
Would be kind of a snowflake, we don't use var args much in the framework, do we?
There was a problem hiding this comment.
Keep in mind this is a method of Route class not Router class which generally won't be needed to be called directly.
There was a problem hiding this comment.
Bah, I meant to comment on the Router method. Sorry.
|
This set of changes is related to #3399 |
|
Merging since there are no more objections. Will update docs too. |
Removed Router::parseExtensions().
|
Might be good to have an upgrade shell pattern for this too. |
|
Thanks for making the upgrade shell issue :) |
|
That's the least i could do 😛 |
Just use Router::setExtensions() instead. setExtensions() now also takes
a single extension as string for first param.