3.0 - Replace intval() with int typecasts #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
added a commit
that referenced
this pull request
Sep 12, 2014
3.0 - Replace intval() with int typecasts
| @@ -200,7 +200,7 @@ public function testChangeOutputFormats() { | |||
| 'error' => array(), | |||
| 'code' => array(), '8', '/code', | |||
| 'file' => array(), 'preg:/[^<]+/', '/file', | |||
| 'line' => array(), '' . (intval(__LINE__) - 7), '/line', | |||
| 'line' => array(), '' . (int)__LINE__ - 7, '/line', | |||
There was a problem hiding this comment.
Don't think a cast is required at all; __LINE__ already is an integer (var_dump(__LINE__); // int 2), however, possibly wrap the calculation in parentheses (__LINE__ - 7) because of the concatenation; alternatively cast the result to a string, instead of the concatenation, if that is the intention ((string)(__LINE__ - 7)) ?
There was a problem hiding this comment.
I agree. This could be done without casting but with () wrapping.
The string cast is not necessary as the concatination automatically casts :)
|
Wouldn't most have ended in 3.x anyway from my 2.x PR? Maybe waiting until after the 2.x => 3.x merge would have avoided some work here. Refs #4570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.