Remove AS from table aliases.

[markstory]

Having AS causes issues with Oracle. While this is not a core driver, the AS keyword is not required by any supported driver.

Refs #4830

[thaJeztah]

Oracle bad :(

Could this be made dependent on the driver used? I find queries without the AS keyword a lot harder to read. I know it's optional, just more verbose and easier to read 😄

[markstory]

Well drivers can implement their own QueryCompiler. Theoretically, not including AS will make the ORM a teeny tiny bit faster as there are fewer bytes to allocate in memory, and send to the db server.

[thaJeztah]

We're entering pico-optimisation territory here!

Generally, I'm ok-ish with this change, because it's simple. However, because Oracle is not a "core" driver (and Oracle is just stubborn to not comply with the SQL standards), I would prefer having this exception in the Oracle driver, if possible.

[ravage84]

@markstory Having theAS makes it the SQL a bit more readable on the other hand 😼

@thaJeztah SQL standards, don't make me laugh 🍭

[thaJeztah]

@ravage84 agreed, most databases don't fully comply with the "standards" (and then again, which version) and many extend on those "standards", but not supporting something very basic as AS is (in my opinion) just being stubborn.

Having said that, my main issue here is the readability of the queries, so on that point, I think we're in agreement 😄

[rchavik]

Having a supported Oracle driver is better. So I don't mind this.

[ADmad]

Sqlserver has couple of failing tests

[htstudios]

I like it for readability too, but nevermind.

[markstory]

Merging, bit we can always revisit this in the future if necessary.