2.1 folder merge #502

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@dereuromark
Member

dereuromark commented Feb 21, 2012

folder fix for merging by default to ensure the class works correctly in all cases, especially with multilevel folders. manual change to other merge schemes added.
fix for default dirs added before starting the test. this ensures that if the tmp folder didnt contain all default dirs, that they are added.

@see ticket http://cakephp.lighthouseapp.com/projects/42648/tickets/2314-folder-class-should-merge-by-default

dereuromark added some commits Feb 21, 2012

folder fix for merging by default to ensure the class works correctly…
… in all cases, especially with multilevel folders. manual change to other merge schemes added. fix for default dirs added.
@lorenzo

This comment has been minimized.

Show comment Hide comment
@lorenzo

lorenzo Feb 21, 2012

Owner

Thanks for contributing! 2.1 is already an RC and we cannot accept new features. We will review these changes again for 2.2 as soon as current version is marked stable

Owner

lorenzo commented Feb 21, 2012

Thanks for contributing! 2.1 is already an RC and we cannot accept new features. We will review these changes again for 2.2 as soon as current version is marked stable

@dereuromark

This comment has been minimized.

Show comment Hide comment
@dereuromark

dereuromark Feb 21, 2012

Member

to be exact this isnt exactly a new feature but a fix for broken functionality (see my reasoning in the ticket). the default case has to make sure that the least possible file loss occurs. which is not the case. actually, quite a lot of data gets lost internally using the current behavior for multilevel directories. the "new default case" would simply leave too many files there as worst case, not deleting them forever).

Member

dereuromark commented Feb 21, 2012

to be exact this isnt exactly a new feature but a fix for broken functionality (see my reasoning in the ticket). the default case has to make sure that the least possible file loss occurs. which is not the case. actually, quite a lot of data gets lost internally using the current behavior for multilevel directories. the "new default case" would simply leave too many files there as worst case, not deleting them forever).

@dereuromark

This comment has been minimized.

Show comment Hide comment
@dereuromark

dereuromark Apr 26, 2012

Member

closed in favor of a clean new approach in 2.2 (respecting all new coding standards)

Member

dereuromark commented Apr 26, 2012

closed in favor of a clean new approach in 2.2 (respecting all new coding standards)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment