2.1 folder merge #502
Closed
2.1 folder merge #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 21, 2012 15:09
… in all cases, especially with multilevel folders. manual change to other merge schemes added. fix for default dirs added.
|
Thanks for contributing! 2.1 is already an RC and we cannot accept new features. We will review these changes again for 2.2 as soon as current version is marked stable |
|
to be exact this isnt exactly a new feature but a fix for broken functionality (see my reasoning in the ticket). the default case has to make sure that the least possible file loss occurs. which is not the case. actually, quite a lot of data gets lost internally using the current behavior for multilevel directories. the "new default case" would simply leave too many files there as worst case, not deleting them forever). |
|
closed in favor of a clean new approach in 2.2 (respecting all new coding standards) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
folder fix for merging by default to ensure the class works correctly in all cases, especially with multilevel folders. manual change to other merge schemes added.
fix for default dirs added before starting the test. this ensures that if the tmp folder didnt contain all default dirs, that they are added.
@see ticket http://cakephp.lighthouseapp.com/projects/42648/tickets/2314-folder-class-should-merge-by-default