Chainable set() #5392
Merged
Chainable set() #5392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test please. |
| public function testSetChained() { | ||
| $this->subject->set('testing', 'value') | ||
| ->set('foo', 'bar'); | ||
| $this->assertEquals(['testing' => 'value', 'foo' => 'bar'], $this->subject->viewVars); |
There was a problem hiding this comment.
I would also add an assert to check type of return value.
There was a problem hiding this comment.
Any idea why such a test fails? Maybe we need to use a real class instead of a trait?
https://travis-ci.org/cakephp/cakephp/jobs/43793912#L231
There was a problem hiding this comment.
You can't use instanceof on traits. You could assertSame($this->subject $result); though.
added 3 commits
December 12, 2014 04:22
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #5318
As suggested makes following possible: