Html Testing Renderer & Code Coverage Improvement #5478
Conversation
Update to the new version of CakePHP
| @@ -200,6 +200,7 @@ function coverage_toggle_all() { | |||
| * @return string | |||
| */ | |||
| public function coverageHeader($filename, $percent) { | |||
| $hash = md5($filename); | |||
There was a problem hiding this comment.
You used spaces instead of tabs for indentation.
|
👍 I like the changes. Since it is for the test suite only this might be OK going into master. Usually new stuff would go into 2.7 here. //EDIT: Sometimes I thought if toggling them would work, that would also be a neat way of combining them without an additional link needed. |
|
Maybe with an PRG approach this could be possible... both options, filters and the options. |
|
I wouldn't make it too complicated for now, given the fact that the webtestrunner will be gone in the next major version. To revive it there we will need to figure out how to pluginize it for 3.0. |
|
There is an idea how to enable the usage of filter with the tests, showing the link when the test fails. Seems the more practical usage, because the specific test is failing and we want to reworkit and don't execute all the other ones generally. |
| } | ||
| $show = $this->_queryString($show); | ||
| $query = $this->_queryString($query); | ||
| return array( $show, $query ); |
|
I am ok with this going into master. Like @dereuromark said the change is only for the test runner. |
|
Maybe squash the commits :) But looks good. |
|
I can clean up any history if necessary before merging. |
|
That should be good, never done it before... Any tutorial how to do it? |
|
I use git rebase -i to squash commits. If you modify history, you'll need to force push your changes. |
|
@tranfuga25s you might find this answer on SO useful. |
Fix failing test Fix CS problem with new code Fix test for code coverage generator Fix tests Fix CS Errors Removed spaces in tabulation
Changed scope of function and fix CS problem
…present CS Fix Update CakeHtmlReporter.php Removed spaces in array return
|
Think i got the idea... The 3 commits are the big changes... i've squashed the fix test and cs's problem commits... Thanks @AD7six and @markstory for the help.... |
|
Great job, thanks! |
Html Testing Renderer & Code Coverage Improvement
|
👏 |
This patch allows to the user of the HtmlRenderer for the testing interface to use the "All options enabled" which will set debug, show passes and codeverage in the same run.
Also fix the problem with the hide/display of code coverage when there is 2 files with the same name in different routes that are reached by the coverage and are showed by the interface. Before only the first one gets its codecoverage diplayed.