Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charset() / headerCharset() methods to CakeEmail class #567

Merged
merged 1 commit into from Mar 16, 2012

Conversation

suzuki
Copy link
Member

@suzuki suzuki commented Mar 16, 2012


original pull request was #564. change branch to 2.2.


CakeEmail have many setter / getter methods for mail headers.
But, charset and headerChaset have a only property.

This is a strange. see below :

  • now
$email = new CakeEmail;

$email->charset = 'ISO-2022-JP';       // strange here
$email->headerCharset = 'ISO-2022-JP'; // strange here

$email->from('suzuki@example.com');
$email->to('suzuki@example.jp);
$emaul->subject('TEST MAIL');
$email->send('TEST MAIL BODY');
  • my patch
$email = new CakeEmail;

$email->charset('ISO-2022-JP');       // this is nice accessor.
$email->headerCharset('ISO-2022-JP'); // this is nice accessor.

$email->from('suzuki@example.com');
$email->to('suzuki@example.jp);
$emaul->subject('TEST MAIL');
$email->send('TEST MAIL BODY');

@lorenzo
Copy link
Member

lorenzo commented Mar 16, 2012

Thanks!

lorenzo added a commit that referenced this pull request Mar 16, 2012
Add charset() / headerCharset() methods to CakeEmail class
@lorenzo lorenzo merged commit 47a2c22 into cakephp:2.2 Mar 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants