Fix for HTML attributes being ignored for individual datetime selects.

[ADmad]

Closes #5829

[markstory]

Tests are failing.

[ADmad]

@markstory Fixed code to ensure all tests pass but I am not satisfied with the change.

While this fixes problem for methods generating individual time selects you still can't pass attributes when using time() or datetime(). For that I think the attributes extraction I added to _singleDatetime() should be moved to _datetimeOptions() instead and also change should be done in DateTimeWidget.

Currently any extra attributes passed to $data of DateTimeWidget::render() are used as attributes for dateWidget template, which doesn't do much good since the default dateWidget does not have any {{attrs}} placeholder. So instead the attributes should be passed to calls done to SelectBoxWidget::render() calls for generating select tags for each datetime part.

[markstory]

Is there much utility in having the same attrs applied to each select in a time/datetime compound input?

[markstory]

What if each public method passed the list of exclusions to _singleDatetime()?

[ADmad]

That's what I had started doing earlier but then switched to using a common list at it was more convenient (lazy). Plus I had thought a single list would be required as I had planned to use it in _datetimeOptions() method.

[ADmad]

Is there much utility in having the same attrs applied to each select in a time/datetime compound input?

Hmm someone might want same class applied to each select but apart from that can't think of any other, so perhaps not a good idea.

[markstory]

One could always use a class on the wrapping div/container in that case.

[ADmad]

One could always use a class on the wrapping div/container in that case.

Yes and one could add the wrapping div with class to the template so using the html attributes passed to datetime() as attributes for dateWidget template isn't very useful.

Instead not being able to specifically set class to select elements can be restrictive as some css framework might dictate that.