WIP - Hash get with non string path #6297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mvdriel |
|
Support for other types (float and boolean) was maybe a bit to advanced for now. But support for null value as path would be, because this was also supported before 2.6 |
markstory
added a commit
that referenced
this pull request
Apr 9, 2015
This was a regression introduced in 2.6.x Refs #6297
markstory
added a commit
that referenced
this pull request
Apr 9, 2015
Port fixes for #6297 to 3.0. This resolves a regression that was introduced in 2.6.x.
|
Thanks for the tests, they have been merged into 2.6 and fixed in a6aefdd |
|
@markstory Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't Hash::get support other types for path?
Before 2.6 it did support null as path, now it throws a InvalidArgumentException for null value and booleans.