XmlView should also have options just as JsonView has. #6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,6 +131,10 @@ public function render($view = null, $layout = null) | |||
| /** | |||
| * Serialize view vars. | |||
| * | |||
| * ### Special parameters | |||
| * `_xmlOptions` You can set an array of custom options for json_encode() this way, e.g. | |||
| * 'format' as 'attribute' instead of 'tags'. | |||
There was a problem hiding this comment.
You mention json_encode in the xml docs.
dereuromark
force-pushed
the
master-xml-options
branch
from
f8d053e
to
c6464fb
Compare
Merged
|
Since the backport was merged, this should probably too (could have been in 3.0.3 btw). |
lorenzo
added a commit
that referenced
this pull request
May 4, 2015
XmlView should also have options just as JsonView has.
|
@dereuromark I prefer not to merge new features a few hours before a release as not at all of people have tested it live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were missing in the XmlView class so far, but needed, if output should be attributes instead of default tags.
Also fixed documentation (plural "attributes).