FormHelper::radio() return broken id attribute when multibyte value options #6635
Conversation
| @@ -495,7 +495,12 @@ public static function underscore($camelCasedWord) { | |||
| */ | |||
| public static function humanize($lowerCaseAndUnderscoredWord) { | |||
| if (!($result = self::_cache(__FUNCTION__, $lowerCaseAndUnderscoredWord))) { | |||
| $result = ucwords(str_replace('_', ' ', $lowerCaseAndUnderscoredWord)); | |||
| $result = str_replace('_', ' ', $lowerCaseAndUnderscoredWord); | |||
| if (function_exists('mb_convert_case') && Multibyte::checkMultibyte($result)) { | |||
There was a problem hiding this comment.
I would just always use mb_convert_case if it exists. There isn't much point in checking the string.
There was a problem hiding this comment.
I tried check exists mb_convert_case only, but many test case broken.
mb_convert_case results not equal ucwords.
eg.
mb_convert_case('contact addForm', MB_CASE_TITLE) = 'Contact Addform'
ucwords('contact addForm'); = 'Contact AddForm'
I seems to be better, if a string that contains a multibyte, it does not convert to title case.
There was a problem hiding this comment.
Given that the inputs to humanize() are documented to be lower_case_and_underscore we should probably look at updating the tests.
I don't like having the code behave differently if the function & data are different because it makes the result of the the method more difficult to predict. Having the method be as consistent as possible is more important to me, as it makes the behavior clearer and more transparent.
|
I tried to Inflector methods support multibtye string. |
Use the mbstring shims we already provide to make Inflector more robust than it currently is. This solves the invalid ID attribute generation in a way that never varies between environments. Refs #6635
|
I switched the code around a bit to use the existing mb* shims and not cause failing tests. Thanks for the help on this @nojimage 👍 |
Bring the fixes for humanize()/underscore() into 3.0.
Port the Inflector fixes from #6635 to 3.0
|
thanks! |
* origin/3.1: (305 commits) Update version number to 3.0.6 New mock objects version causes our test suites to fail. Update FloatType.php Update DateTimeType.php Updated docBlock Fix empty query expressions for generating invalid SQL. Add tests for empty expression objects in association conditions. Add option to disable local XML file parsing. Port the Inflector fixes from #6635 to 3.0 Fix typo in error template file name. Add test for ProgressHelper output with options. Add missing doc blcoks. Fix getOriginal() not preserving nulls. Fix incorrect doc blocks and PHPCS. Fixed @SInCE in QueryExpressionTest Added __call() on QueryExpression to allow for and() and or() to be called transparently. Implements #6477 Added default message for InvalidCsrfTokenException Updated thrown exception messages to be more descriptive of the cause replace DS with DIRECTORY_SEPARATOR in filesystem sub-package Added InvalidCsrfTokenException. Implements #6546 Use ProgressHelper in i18n task. ...
In CakePHP 2.6.4
I expects return like,
But, actual result is,
I traced the
FormHelper::radio()method, and I found the method callInflector::humanize()with multibyte string.in Inflector::humanize() using
ucwords, butucwordsnot support multibyte string.To solve this problem,
Inflector::humanize()will usemb_convert_case()if the function exists.