Allow injection of types not just mapping #8048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would allow to have configurable types and be able to move some logic currently done at the `Behavior` level instead but would fit the Type much more (i.e. data encryption)
|
Could we get some tests to make sure this change doesn't break in the future. |
|
Sure! |
|
@markstory, I think this is good to go now. |
| Type::map('foo2', $fooType); | ||
| $map = Type::map(); | ||
| $this->assertEquals($fooType, $map['foo2']); | ||
| $this->assertEquals($fooType, Type::map('foo2')); |
lorenzo
added a commit
that referenced
this pull request
Jan 18, 2016
Allow injection of types not just mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow to have configurable types and be able to move some logic currently
done at the
Behaviorlevel instead but would fit the Type much more (i.e. data encryption)