Move name inflection into routing.

[markstory]

This moves inflection into a more 'correct' place, but causes a bunch of other issues like breaking route symmetry between parse() and url().

I feel like the Controller location is less troublesome as the routing layer cares very little about the casing whereas the controller cares about its name being properly inflected.

⚠️ I think this is a bad idea, but I wanted to discuss this and other options in this pull request.

Refs #8085

[lorenzo]

Isn't using a lowercase controller name in the router always an error? We could just not inflect it, and at the controller actors level throw an exception or at least trigger an error.

I think this is in the top list of problems in cake, one we try to correct with hi sort of code but that often breaks applications in case sensitive file systems

[markstory]

The routing layer doesn't care about the the casing of the controller names, outside of the casing being consistent between parsing/matching which is something that would break with this change. Previously the following would work:

Router::connect('/:controller/:action/*');
$url = '/articles/view/1';
$this->assertSame($url, Router::url(Router::parse($url)));

That would no longer be the case after this change, and that is the kind of breakage I'm worried about.

You are right though that controller construction and usage requires a CamelCase controller name.

[lorenzo]

i agree that it is bad to break the symmetry in the router. That is why I suggested triggering an error in the controller factory dispatcher, having to use the inflector is a clear indicator of a user mistake

[ADmad]

Reading the original issue #8081 again I see that the problem occurred due to using lower cased controller name examples in url for a url scheme which was using Route class. Since Route class doesn't do any inflection the url should have Examples isn't it? I think in this case the route shouldn't match and an exception should be thrown.

[ADmad]

Hmm throwing an exception at router level might not be feasible since child classes could inflecte the URL parts parsed by Route so I guess doing so in controller factory dispatcher as @lorenzo suggested would be the best.

[ADmad]

Since we are striving to reduce inflections I think this camelization of plugin name in controller factory should also be removed. DashedRoute already handles inflection of vendor namespaced plugin names properly so just InflectedRoute needs to be fixed.

[markstory]

I think in this case the route shouldn't match and an exception should be thrown.

The route matched because :controller accepts any controller name.

doing so in controller factory dispatcher as @lorenzo suggested would be the best.

I can get behind that. I'll make another pull request.